New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"copy to clipboard" box too tall #433
Comments
Well, Flash certainly can't be avoided, because you can't do copying to clipboard in Javascript. Why else would good programmers use Flash, besides when it's absolutely necessary? ;) GitHub uses Javascript for copying the repository address? Are you sure? Because when I right click it, I see the "About Adobe Flash Player". You mean the https://github.com/USERNAME/REPOSITORY.git address, right? Try to disable plug-ins, maybe one of them is messing it up. Because in my default Chrome it's normal. |
You are so right that the GitHub uses Flash to copy the repository URL to the clipboard. I came to the wrong conclusion when I found "js-clippy" in the HTML source, and I was able to use the button -- even though I don't have any "allow plug-ins" exceptions for github.com in Chrome. When I "block all" plug-ins, the copy button is disabled. I'll have to explore how the GitHub Flash making it past the Plug-in restriction settings. Thanks! |
@slothbear Can this issue be closed? |
Use explicit height for clippy instead of the default, issue #433.
It appears that this is resolved. Please reopen if it continues to be an issue. |
A commit made in #433 / #440 is broken in recent versions of Chrome which do not like Objects to extend past their bounds, the oversizing of the area causes Chrome to trip out (at least on Linux, I assume on Windows and OS X too) because it extends into the text area and thus prevents any manual copy and paste. This could also be broken by other changes and might not necessarily be related to Chrome at all. The size of 24px was manually selected after adjusting the maximum size in inspector until I could copy.
This is a minor visual issue, but the fix may be easy. I'm running Chrome with the preferences setting:
Plug-ins: click to play
When I go to any gem page, the github_clippy.swf that supports "copy to clipboard" appears as a tall grey box. The gray box part is correct -- that's what I'm supposed to click to play. But the size of the box is 110x150, much larger than the 14x14 clipboard icon. It looks like this:
I see the same 100x150 box on the clippy for the "gem install" line at the top:
Would it be possible to add a height and width to these items so they don't overlap other stuff? Or... I noticed that Github uses a js-clippy for copying the repository address. Maybe Flash can be avoided altogether. Or... just close this issue, it is a minor nit.
The text was updated successfully, but these errors were encountered: