Remove version history model and table

[sonalkr132]

Attempt - II

My previous PR was roasted #1277:

PG::DependentObjectsStillExist: ERROR: cannot drop table version_histories because other objects depend on it

Hopefully this will work 🙏 👷

[simi]

Can you update https://github.com/rubygems/rubygems.org/blob/master/CONTRIBUTING.md#database-layout also? I think there's a rake task for that in https://github.com/rubygems/rubygems.org/blob/master/lib/tasks/gen_erd.rake.

[sonalkr132]

@simi thanks. I have updated it.

What do people think about using png instead of svg? With svg, everything gets smushed together and I am seeing columns types like string ∗ U (in place of string *).
svg:
https://github.com/sonalkr132/rubygems.org/blob/force_r-version_history/doc/erd.svg

png:

[simi]

I can see properly rendered svg on your link, but it wasn't updated for a while.
I have no idea what's preferred here now. Do we need Doorkeeper and LogTicket in erd scheme?

If we need to keep erd updated, we can add it to specs (I can contribute this).

[dwradcliffe]

Yes let's keep it updated. Png is fine with me if it renders fine/better.

---

David Radcliffe

On Tue, May 24, 2016 at 9:05 AM, Josef Šimánek notifications@github.com
wrote:

I can see properly rendered svg on your lin, but it wasn't updated for a
while.
I have no idea what's preferred here now. Do we need Doorkeeper and
LogTicket in erd scheme?

If we need to keep erd updated, we can add it to specs (I can contribute
this).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1285 (comment)

[sonalkr132]

@simi this is what svg looks on my computer.

EDIT: link

[simi]

Weird, browser and image viewer is ok with that. I think we can open new issue for this, since it is not related to this PR.

[dwradcliffe]

Ohhh! The problem is there is another table! The error message even says that, I just didn't notice. There is a version_histories_import table which is linked to the version_histories table. I have tested this on staging and it works. I'm going to merge this because I've already run this but we still need to remove the other table. @sonalkr132 can you send a new PR to remove the version_histories_import table?

[sonalkr132]

we are putting the table to peace 💀 manual way.