Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined var response from ordered_names #1368

Merged
merged 1 commit into from
Jul 6, 2016
Merged

Remove undefined var response from ordered_names #1368

merged 1 commit into from
Jul 6, 2016

Conversation

sonalkr132
Copy link
Member

Solves:

Occurred: NameError (#30372507)
Full report at https://app.honeybadger.io/projects/40972/faults/30372507
NameError: undefined local variable or method `response' for #Class:0x000000060b6bb0
Summary
api/compact_index#names
URL: https://rubygems.org/names

@dwradcliffe
Copy link
Member

👍
Are we missing a test?

@sonalkr132
Copy link
Member Author

We don't have unit test for any of compact_index functions. I have been hoping that we can refactor it out of rubygems model and write unit test along the way.

@dwradcliffe
Copy link
Member

Sounds like a good plan.

@dwradcliffe dwradcliffe merged commit 7a6d968 into rubygems:master Jul 6, 2016
@sonalkr132 sonalkr132 deleted the undef_response branch July 6, 2016 12:37
@rubygems-deployer rubygems-deployer temporarily deployed to staging July 6, 2016 12:39 Inactive
@dwradcliffe dwradcliffe temporarily deployed to production July 12, 2016 02:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonalkr132 @dwradcliffe @rubygems-deployer