Prevent yanking of popular gem version

[shlok007]

Refers to issue #1226 .

Gem yanks will only be allowed if the version has less than 15,000 downloads. This will allow relatively unused gems to be yanked freely, while popular gems will have a shorter period of time to realize they have a legit reason to yank.

[jvanbaarsen]

What do you think about adding a ? to this method? So it becomes can_yank?? Or maybe yankable??

[shlok007]

The reason I didn't use yankable is because it isn't an actual word by dictionary.

[jvanbaarsen]

Ah ok :-) Can we in that case at the ??

[sonalkr132]

NOTE: This PR is an alternate solution to PR #1371

Thank you for your PR @shlok007 💙
Instead of adding a conditional in controller, couldn't this be implemented as a validation on deletion model?

[shlok007]

Thank you. 😃
What you suggested might be a better way but still I would have to modify the controller and add the condition to display the appropriate message after the yank fails. This is the current text which is rendered on a yank failure which won't be appropriate in this situation.

[sonalkr132]

This is the current text which is rendered on a yank failure which won't be appropriate in this situation.

IMHO, the current text is not appropriate for failure of @deletion.save as it can return false for reasons other than version already being deleted. I believe using conventional @deletion.errors should be fine unless I am missing something here.

cc: @dwradcliffe

[shlok007]

@jvanbaarsen Done. :)

[indirect]

I agree with @sonalkr132's suggestion, and I think the error message should come from a validation.

I would also like this to show a clear error message with wording like "Gem versions cannot be yanked after they have been downloaded over 15,000 times".

@sonalkr132, if you have time now, I would be happy to merge a PR based on this that makes those changes.

[sonalkr132]

if you have time now, I would be happy to merge a PR based on this that makes those changes.

@shlok007 wanted to work on this. I am sure he can make requested change 👌

[indirect]

👍💯

[shlok007]

I have made a separate PR covering those changes. #1396 . Closing this.