Use translation for search gem string #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
reviewed
Dec 20, 2016
| @@ -36,17 +36,17 @@ | |||
| <div class="header__nav-links-wrap"> | |||
| <% if request.path_info == "/" %> | |||
| <%= form_tag search_url, :id => "main-search", :class => "header__search-wrap--home", :method => :get do %> | |||
| <%= search_field_tag :query, params[:query], :placeholder => "Search Gems…".html_safe, :class => "header__search" %> | |||
| <%= search_field_tag :query, params[:query], :placeholder => t('layouts.application.header.search_gem').html_safe, :class => "header__search" %> | |||
There was a problem hiding this comment.
Hi @spk , I think this would work without layouts.application as well.
There was a problem hiding this comment.
Hi @sonalkr132 , indeed fixed in 1702929
sonalkr132
approved these changes
Dec 22, 2016
dwradcliffe
approved these changes
Dec 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use I18n for "Search gems" string