Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that test pass even when elasticsearch is default #1591

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Ensure that test pass even when elasticsearch is default #1591

merged 2 commits into from
Apr 3, 2017

Conversation

sonalkr132
Copy link
Member

This required that we import_and_refresh whenever we test search.

@sonalkr132
Remove setup and teardown methods from integration test of search
2b11e82 
They need not run before every test case. We don't need gem_downloads
introduced in rubygems@83a3d0b
as `ruby-ruby` will always be on first page.
@segiddins
Copy link
Member

👍 looks good!

dwradcliffe
dwradcliffe requested changes Mar 29, 2017
View reviewed changes
Copy link
Member

@dwradcliffe dwradcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that AWS supports ES 5.1 now, so we should upgrade before enabling this. It will be much safer to upgrade before anyone is using it.

Let's start testing the app code against 5.1 and make any changes necessary.

@sonalkr132
Import records to ES index before testing search
ad2aad9 
This ensures that tests pass even when ES is default.
`force: true` ensures that old index was first deleted.
@sonalkr132 sonalkr132 changed the title Enable elasticsearch Ensure that test pass even when elasticsearch is default Mar 29, 2017
@sonalkr132
Copy link
Member Author

Let's start testing the app code against 5.1 and make any changes necessary.

I have sent a different PR #1593 for ES update. This PR ensures that tests pass even when ES is default.

@sonalkr132 sonalkr132 merged commit dcdfa13 into rubygems:master Apr 3, 2017
@sonalkr132 sonalkr132 deleted the enable-es branch April 3, 2017 19:30
@sonalkr132 sonalkr132 added this to the Search milestone Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwradcliffe dwradcliffe dwradcliffe approved these changes

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
Search
Development

Successfully merging this pull request may close these issues.
4 participants
@sonalkr132 @segiddins @dwradcliffe @rubygems-deployer