Ensure ts used in versions file header and db query is the same #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
force-pushed
the
versions-date
branch
8 times, most recently
from
9416058
to
5735a3c
Compare
If a version was updated between the time versions data were queried and versions file header was created, the version would have been skipped. since we use versions file header as marker for dynamic part of versions file, the updated version was never showing up in (compact) index.
sonalkr132
force-pushed
the
versions-date
branch
from
5735a3c
to
82a2087
Compare
sonalkr132
added a commit
to sonalkr132/rubygems.org
that referenced
this pull request
Oct 19, 2021
This was unintentially removed in rubygems#2811. causes different times for @created_at and version file header occasionally.
sonalkr132
added a commit
to sonalkr132/rubygems.org
that referenced
this pull request
Oct 19, 2021
This was unintentially removed in rubygems#2811. causes different times for @created_at and version file header occasionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a version was updated between the time versions data were queried
and versions file header was created, the version would have been
skipped. since we use versions file header as marker for dynamic
part of versions file, the updated version was never showing up in
(compact) index.
closes: #2808