Add pop-up when a WebAuthn credential is deleted

[jenshenny]

What problem are you solving?

When deleting a WebAuthn device, there should be a pop-up or alert to make sure that this action was not made by accident.

What approach did you choose and why?

Like when deleting an API key, added a confirmation associated with the delete button

What should reviewers focus on?

The phrasing of the confirmation message

Testing

1. Have a Webauthn device on a user account
2. When the delete button is pressed an alert pops up confirming the removal of the device.

[ericherscovich]

Looks good to me! My one suggestion is perhaps adding a system test that clicks Cancel instead and ensuring the authn key is not deleted.

[codecov]

Codecov Report

Merging #3708 (900ffd0) into master (0941d80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3708   +/-   ##
=======================================
  Coverage   98.74%   98.75%           
=======================================
  Files         207      207           
  Lines        5115     5130   +15     
=======================================
+ Hits         5051     5066   +15     
  Misses         64       64           

Impacted Files	Coverage Δ
app/mailers/mailer.rb	100.00% <100.00%> (ø)
app/models/webauthn_credential.rb	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jchestershopify]

LGTM, seconding @ericherscovich's suggestion.

[jenshenny]

My one suggestion is perhaps adding a system test that clicks Cancel instead and ensuring the authn key is not deleted.

Good call! Done ✅