No duplication in just updated #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2012 17:12
…h versions. Return only the latest version.
…sive just_updated test
| @@ -54,6 +54,10 @@ def self.latest(limit=5) | |||
| with_one_version.order("created_at desc").limit(limit) | |||
| end | |||
|
|
|||
| def self.just_updated(limit=5) | |||
| with_versions.order("updated_at desc").limit(limit).map { |rg| rg.versions.last } | |||
There was a problem hiding this comment.
Ah, I'm not sure I like the implementation of this. The rubygem model should not have a finder class method which returns instances of Version. Also, I don't believe this will scale well or work correctly with gems with a large amount of versions (full table join, limit applied to the joined gems with versions, not to the unique count of gems).
|
Looking like this is just a few new tests now. Merging... |
|
Hmmm, it looks like this broke this tests: http://travis-ci.org/rubygems/rubygems.org/builds/934871 Reverting... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the most recent updates through Rubygem model rather than through Version. Eliminate duplication.