Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handle to user json responses #928

Merged
merged 1 commit into from
Apr 5, 2015
Merged

Add handle to user json responses #928

merged 1 commit into from
Apr 5, 2015

Conversation

arthurnn
Copy link
Member

@arthurnn arthurnn commented Apr 4, 2015

[fixes #927]

cc @AaronLasseigne

@@ -73,22 +73,22 @@ class UserTest < ActiveSupport::TestCase
assert_nil User.authenticate(@user.email, "bad")
end

should "only have email when boiling down to JSON" do
should "have email and handle on JSON" do
json = MultiJson.load(@user.to_json)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON.parse

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call.

@maclover7
Copy link
Contributor

👍

arthurnn pushed a commit that referenced this pull request Apr 5, 2015
Add handle to user json responses
@arthurnn arthurnn merged commit 2bc7da0 into master Apr 5, 2015
@arthurnn arthurnn deleted the add_handle branch April 5, 2015 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owners API endpoint not returning owners (sometimes)
3 participants