-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows generated .bat commands broken for JRuby on RubyGems 3 / Bundler 2 #2873
Comments
See PR #2876. Uses the same logic as |
Thanks @MSP-Greg! @karlhe I think you can double check that @MSP-Greg's fix works by manually applying his patch to your rubygems installation (it's very simple), and then reinstalling You can revert to your previous rubygems if you want after you confirm the fix with |
Replaced the file at
Thanks! |
2876: installer.rb - fix #windows_stub_script r=hsbt a=MSP-Greg Use ruby_exe in heredocs (scripts) instead of ruby.exe. Currently, binstubs only work for standard MRI exe ('ruby.exe'). See Issue #2873 # Tasks: - [X] Describe the problem / feature - [ ] Write tests - [X] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: MSP-Greg <msp-greg@users.noreply.github.com>
It still seems to be the same behavior, I don't think the PR actually made it into 3.0.6? rubygems/lib/rubygems/installer.rb Line 802 in 9c142f5
Still looks like the old one |
Ah, Sorry. I missed this at 3.0.5 and 3.0.6, I will release with 3.0.7. |
2876: installer.rb - fix #windows_stub_script r=hsbt a=MSP-Greg Use ruby_exe in heredocs (scripts) instead of ruby.exe. Currently, binstubs only work for standard MRI exe ('ruby.exe'). See Issue #2873 # Tasks: - [X] Describe the problem / feature - [ ] Write tests - [X] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: MSP-Greg <msp-greg@users.noreply.github.com>
I'm having a problem or would like to suggest a feature.
My current problem is the bundle command does not work as expected with JRuby on Windows.
Filed an issue against JRuby a while back (jruby/jruby#5632), but I don't think it's a problem on the JRuby side.
It simply appears as if the .bat files are not generated correctly. The contents of bundler.bat/bundle.bat are:
For comparison, it looks like this in my JRuby 9.2 folder (which is using older Rubygems/Bundler):
On the surface
jbundle
seems to work but then rails.bat, rake.bat, etc are still defined like this:So any command other than
jbundle install
will end up failing anyway.This issue is related to:
gem
Here are my current environment details:
Bundler: 2.0.4
JRuby 9.2.8.0
Windows Server 2016 Standard
I will abide by the code of conduct.
The text was updated successfully, but these errors were encountered: