Fix undefined method 'platform' for nil::NilClass in ruby processes when gem cleanup is run. #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen running gem cleanup.
| FileUtils.rm_rf(File.join @default_spec_dir, "#{b1.full_name}.gemspec") | ||
|
|
||
| # Require gems that have not been removed. | ||
| assert_require 'a/b' |
There was a problem hiding this comment.
Run against the current master code, this raises the "undefined method 'platform'" exception. With the changes in this PR, it passes (no exception is raised).
|
Looks good to me. |
djberg96
added a commit
that referenced
this pull request
Sep 25, 2015
Fix undefined method 'platform' for nil::NilClass in ruby processes when gem cleanup is run.
djberg96
added a commit
that referenced
this pull request
Sep 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.