Revamp appveyor.yml file. #1590
Conversation
| @@ -1,38 +1,38 @@ | |||
| --- | |||
| version: "{build}" | |||
| version: '{build}' | |||
| branches: | |||
There was a problem hiding this comment.
We do want these other branches
There was a problem hiding this comment.
@segiddins Why, do we ever backport? It's no problem to add them, just curious.
There was a problem hiding this comment.
Yes, we have in the past and might need to in the future, especially for security-related issues.
|
What about this line? Is that |
Added additional branches, set TRAVIS env variable.
|
@segiddins Ok, I've updated the PR to include the additional branches. @simi I've updated the PR so that it sets ENV['TRAVIS'] first. You're right that appveyor does export ENV["CI"] - it's set to true - so we should probably look at converting all instances of those in a future PR if "CI" serves as a sort of universal environment variable for continuous integration services in general. |
|
@duckinator I'll let you review this |
|
@simi we export the @segiddins looking at it now. |
|
📌 Commit e66fd6f has been approved by |
|
⚡ Test exempted - status |
Revamp appveyor.yml file. This is an update to the appveyor.yml file. A bit about the changes: * Only tests the master branch. I'm not sure why we care about other branches but I can add them if you feel it's necessary. * Uses Powershell in the "install" portion instead of cmd.exe. This makes it easier to skip gem installation if the dependencies we need are already installed. PS is just better in general. * Removes all that Travis stuff. I have no idea what that's about. This ain't Travis. * Caches the gem directories for each distribution. We don't need to re-provision gems every time we build, so this speeds up the build process. * No after-test task. No idea why we care about that. I tried it with local settings on my own fork and it worked fine. All the builds, including 1.9.3, were green.
This is an update to the appveyor.yml file. A bit about the changes:
I tried it with local settings on my own fork and it worked fine. All the builds, including 1.9.3, were green.