Fix tar headers with a 101 character name #1612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This attempts to fix #1608. The algorithm used by
Gem::Package::TarWritter#split_name
is revised and changed such that for names longer than 100 bytes (when split is required) it:name
is returned,prefix
is returned (if we splitname
into newname
andprefix
, and prefix appears to be empty, then the result is incorrect as we put the newname
plus no prefix toTarHeader
but the newname
differs from the original one, so the resultant path is incorrect - this happens to the current implementation ofsplit_name
found in master, for example when the path is 101-characters long and starts with"/"
),prefix
as possible (but not more than 155 bytes) - this is how the GNU tar works, at least from my observation,The PR consists initially of two commits, first with tests only (to show, where the old implementation fails) and second containing the new implementation of
#split_name
.Tasks:
I will abide by the code of conduct.