Gem::Requirement.create treat arguments as variable-length #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix the errors. |
|
Is this worth the performance penalty? |
|
Yes. |
We can write not only `Gem::Requirement.create([">= 1.2", "<= 1.3"])`
but also `Gem::Requirement.create(">= 1.2", "<= 1.3")`
negito6
force-pushed
the
requirement-create-variable-length-arg
branch
from
771c96b
to
6526dd0
Compare
|
Thanks your reviews. I feel the current style add_dependency 'example', '>= 1.0.0.a', '< 2.0.0'But it is only my subjectivity. Positive comments here will show the worth. |
drbrain
reviewed
Feb 1, 2017
lib/rubygems/requirement.rb
Outdated
| @@ -51,7 +51,11 @@ class BadRequirementError < ArgumentError; end | |||
| # If the input is "weird", the default version requirement is | |||
| # returned. | |||
|
|
|||
| def self.create input | |||
| def self.create *inputs | |||
| return create inputs if inputs.length > 1 | |||
There was a problem hiding this comment.
Why not new inputs? This should match L63 right?
There was a problem hiding this comment.
Certainly it is useless method call. I fixed it.
|
@homu r+ |
|
📌 Commit 4455566 has been approved by |
homu
added a commit
that referenced
this pull request
Feb 1, 2017
… r=drbrain
Gem::Requirement.create treat arguments as variable-length
# Description:
This PR enables `Gem::Requirement.create` to treat arguments as variable-length.
Now, we can write only
```ruby
Gem::Requirement.create([">= 1.2", "<= 1.3"])
```
New style will be supported
```ruby
Gem::Requirement.create(">= 1.2", "<= 1.3")
```
______________
# Tasks:
- [x] Describe the problem / feature
- [x] Write tests
- [x] Write code to solve the problem
- [x] Get code review from coworkers / friends
I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status |
|
I appreciate your review and merge ! @segiddins @drbrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables
Gem::Requirement.createto treat arguments as variable-length.Now, we can write only
New style will be supported
Tasks:
I will abide by the code of conduct.