Reset hooks in test cases #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Re the Appveyor fails, I've got an issue filed there with a script that updates all their ruby builds. There may still be intermittent failures due to file artifacts; I wasn't sure if 'cleaning' them (disk I/O) in Previously, I was cleaning them on a test method basis, probably be easier and more maintainable if they were cleaned in 'local teardown' (on a test file basis). I've seen issues when disk I/O slows down Appveyor, not sure about Travis. |
This was referenced Jun 1, 2018
Merged
|
@bundlerbot r+ |
|
📌 Commit 28e9961 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 8, 2018
Reset hooks in test cases # Description: Closes #2296. cc @MSP-Greg # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #2296. cc @MSP-Greg
Tasks:
I will abide by the code of conduct.