Backport ruby core changes #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
approved these changes
May 29, 2019
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
May 29, 2019
2778: Backport ruby core changes r=hsbt a=hsbt # Description: Picked from http://github.com/ruby/ruby . It updates the fragile tests on our CI service that is https://rubyci.org ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: aycabta <aycabta@gmail.com> Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
Build succeeded |
ghost
merged commit 
|
I don't understand 7cb5316. It only adds a top level require, so it seems unrelated to the commit message "Show documents when completion". Is that backport correct? |
|
Thanks for keeping rubygems in sync with the changes from ruby-core, by the way! ❤️ |
You are right. I got its detail from @aycabta. He encountered an issue related to https://bugs.ruby-lang.org/issues/14747. |
|
Thanks for clarifying, no problem! Hopefully confused git archaeologists will end up finding this PR 😃 |
hsbt
pushed a commit
that referenced
this pull request
Jun 13, 2019
2778: Backport ruby core changes r=hsbt a=hsbt # Description: Picked from http://github.com/ruby/ruby . It updates the fragile tests on our CI service that is https://rubyci.org ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: aycabta <aycabta@gmail.com> Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Picked from http://github.com/ruby/ruby . It updates the fragile tests on our CI service that is https://rubyci.org
Tasks:
I will abide by the code of conduct.