Fix underscore version selection for bundler #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
underscores_vs_bundler_version_finder
branch
2 times, most recently
from
362d70a
to
894a224
Compare
Previously it wouldn't play nice with the bundler version finder.
deivid-rodriguez
force-pushed
the
underscores_vs_bundler_version_finder
branch
from
a641da4
to
d8bb815
Compare
|
I added a test for this fix. "MacOS 2.3.x" check failed initially but I think it was unrelated, so I restarted it and it's now green. The main benefit of this fix is that it allows users to easily skip the "BUNDLED WITH" automatic bundler version locking by specifying the desired version surrounded by underscores ( |
hsbt
approved these changes
Sep 24, 2019
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Sep 24, 2019
2906: Backport ruby core r=hsbt a=hsbt # Description: Fixed the warnings with keyword separation feature of Ruby 2.7 and rondomly failed on GitHub Actions. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2908: Fix underscore version selection for bundler r=hsbt a=deivid-rodriguez # Description: When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Fixes rubygems/bundler#7345. Closes rubygems/bundler#7349. Co-authored-by: Kazuhiro NISHIYAMA <zn@mbf.nifty.com> Co-authored-by: Jeremy Evans <code@jeremyevans.net> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build failed (retrying...) |
ghost
pushed a commit
that referenced
this pull request
Sep 24, 2019
2908: Fix underscore version selection for bundler r=hsbt a=deivid-rodriguez # Description: When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Fixes rubygems/bundler#7345. Closes rubygems/bundler#7349. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build failed |
|
@bundlerbot retry |
ghost
pushed a commit
that referenced
this pull request
Sep 25, 2019
2906: Backport ruby core r=hsbt a=hsbt # Description: Fixed the warnings with keyword separation feature of Ruby 2.7 and rondomly failed on GitHub Actions. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2908: Fix underscore version selection for bundler r=hsbt a=deivid-rodriguez # Description: When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Fixes rubygems/bundler#7345. Closes rubygems/bundler#7349. Co-authored-by: Kazuhiro NISHIYAMA <zn@mbf.nifty.com> Co-authored-by: Jeremy Evans <code@jeremyevans.net> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
hsbt
pushed a commit
that referenced
this pull request
Feb 18, 2020
2906: Backport ruby core r=hsbt a=hsbt # Description: Fixed the warnings with keyword separation feature of Ruby 2.7 and rondomly failed on GitHub Actions. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2908: Fix underscore version selection for bundler r=hsbt a=deivid-rodriguez # Description: When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Fixes rubygems/bundler#7345. Closes rubygems/bundler#7349. Co-authored-by: Kazuhiro NISHIYAMA <zn@mbf.nifty.com> Co-authored-by: Jeremy Evans <code@jeremyevans.net> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
hsbt
pushed a commit
that referenced
this pull request
Feb 18, 2020
2906: Backport ruby core r=hsbt a=hsbt # Description: Fixed the warnings with keyword separation feature of Ruby 2.7 and rondomly failed on GitHub Actions. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2908: Fix underscore version selection for bundler r=hsbt a=deivid-rodriguez # Description: When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Fixes rubygems/bundler#7345. Closes rubygems/bundler#7349. Co-authored-by: Kazuhiro NISHIYAMA <zn@mbf.nifty.com> Co-authored-by: Jeremy Evans <code@jeremyevans.net> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When rubygems' underscore version selection is used with bundler itself, it doesn't work. This PR should fix it.
Tasks:
I will abide by the code of conduct.
Fixes rubygems/bundler#7345.
Closes rubygems/bundler#7349.