Install to correct plugins dir when using --build-root
#3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2020
deivid-rodriguez
force-pushed
the
buildroot
branch
from
63feb74
to
1cc1b19
Compare
deivid-rodriguez
force-pushed
the
buildroot
branch
from
f3926ba
to
ba4df51
Compare
|
Can this be backported for 3.2? |
|
Yes, I hope that we include all unreleased bug fixes in the final 3.2 release. |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Install to correct plugins dir when using `--build-root` (cherry picked from commit a969c0f)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Install to correct plugins dir when using `--build-root` (cherry picked from commit a969c0f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We missed this case when introducing the new plugins layout.
As a bonus, I added a few minor improvements and refactoring to this option.
Fixes #3971.
Tasks:
I will abide by the code of conduct.