Fix --build-root flag under Windows
#3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to trim drive letters to generate a valid path.
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix `--build-root` flag under Windows (cherry picked from commit 9b25442)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix `--build-root` flag under Windows (cherry picked from commit 9b25442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The
--build-rootflag is broken under Windows, because invalid paths are generated.What is your fix for the problem, implemented in this PR?
Trim drive letters to generate a valid path.
This PR also includes some minor refactorings.
This issue was discovered by the regression spec added in #3972.
Tasks:
I will abide by the code of conduct.