Restore change to copy global with/without config locally upon bundle install
#4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5e85472.
This reverts commit 365b463.
This reverts commit 744c03d.
This reverts commit 0598cbb, but keeps the same spec, but "inverted" to clarify that doing this was a feature, not a bug. This behavior is not present on bundler 3 though, because it won't remember CLI options, and what the current code does is to fake `--with` and `--without` where given as CLI options if they are configured globally. We don't want to preserve this behaviour on the next major version, so the same spec that was present on master (setting are not automagically saved from global to local config) is kept on bundler 3. In addition to that, I'm adding another spec representing the realworld behavior that was broken for people when I introduced 0598cbb. Note that this spec does not currently pass on bundler 3 (again, because bundler 3 does not remember CLI options automatically), but I plan to fix that by changing `bundle config` default to save configuration locally to the application, not globally.
deivid-rodriguez
force-pushed
the
revert_change_to_copy_global_to_local_config
branch
2 times, most recently
from
2828400
to
d77f1bf
Compare
4 tasks
deivid-rodriguez
deleted the
revert_change_to_copy_global_to_local_config
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 16, 2020
…o_local_config Restore change to copy global with/without config locally upon `bundle install` (cherry picked from commit 352a1f5)
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Turns out #3666, which I thought was a bug fix, broke things for some people.
The problem is that people are righteously assuming that
bundle configshould save configuration locally to the application, but currently it doesn't work like that.This "feature" of
bundle installautomatically copying globalwithandwithoutconfiguration to the local configuration was creating the false impression thatbundle configworked as you would expect and keeping people's expectations working.What is your fix for the problem, implemented in this PR?
I considered just making the switch and changing
bundle configto be local but a few examples come up that could break because of doing that, so for the time being I'm just going to revert the change and release a patch release with the revert.Fixes #4142.
Make sure the following tasks are checked