Support repositories with default branch not named master #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
support_main
branch
from
52b4678
to
cf8753d
Compare
|
If I understand this well, this also fixes "bug" when |
|
Now that you mention it, yeah, it sounds like that's what the old code was doing! |
deivid-rodriguez
force-pushed
the
support_main
branch
from
cf8753d
to
acb6f91
Compare
|
It should be ready now unless CI proves me wrong! |
simi
approved these changes
Jan 5, 2021
deivid-rodriguez
force-pushed
the
support_main
branch
from
acb6f91
to
de963bc
Compare
|
CI got a flaky issue on jruby which I'm trying to address at #4235. I'll rebasing to see how this plays with the latest CI additions, and then merge. |
Bundler 3 no longer prints these messages, but we can force them with `--verbose`.
… master Without having to pass an explicit `:branch` argument. Now git source string representation no longer shows branch information unless the repository has already been cloned and we know what the default branch is.
deivid-rodriguez
force-pushed
the
support_main
branch
from
de963bc
to
c869343
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 11, 2021
Support repositories with default branch not named master (cherry picked from commit 6e032a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bundler doesn't support non-master default branches, so you can't currently point to, for example, simplecov's repo, unless you add an explicit
branch: => "main"to your git sources configuration.Bundler should just work in this case without having to make the default branch explicit.
What is your fix for the problem, implemented in this PR?
My fix is to make sure the code doesn't assume a specific branch until we have actually cloned the repository. This means that when a git sources is printed, it no longer includes "master" if the source is only present in the
Gemfileand has not yet been installed.Fixes #4009.
Make sure the following tasks are checked