Restore support for old git versions #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it independent of whether we use the `-C` flag or not.
hsbt
reviewed
Jan 5, 2021
deivid-rodriguez
force-pushed
the
simplify_errors_on_git_proxy
branch
from
bc180c6
to
7ca61c2
Compare
simi
approved these changes
Jan 5, 2021
|
Thanks @simi!! |
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 11, 2021
Restore support for old git versions (cherry picked from commit 9e48dbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#4196 introduced using the
git -Cflag to workaround some JRuby issues on Windows. However, the-Cflag is only supported since git 1.8.5, and some environments still have an old git. In particular, CentOS 7 ships an older git.What is your fix for the problem, implemented in this PR?
My fix is to restore the previous behavior if running on old git version, and to schedule dropping support for old git versions in bundler 3.
Fixes #4229.
Make sure the following tasks are checked