Make ruby -r work with bundle exec
#4616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several specs don't need these gems installed globally.
deivid-rodriguez
force-pushed
the
bundle_exec_ruby
branch
3 times, most recently
from
8c7226e
to
376c5c2
Compare
It was ignoring executable extensions, which is the only hint `File.executable?` uses on Windows to figure out executability.
When `bundle exec`'ing to `ruby` itself, direct `-r` flags get run before `RUBYOPT`, so they get run before `bundler/setup` gets the chance to be required. This seems like a flag precedence issue in ruby, but we can workaround it.
deivid-rodriguez
force-pushed
the
bundle_exec_ruby
branch
from
376c5c2
to
0b560f0
Compare
|
I'm closing this since it doesn't work for shell scripts invoking ruby. I will extract some changes from here that still make sense (fixes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When
bundle exec''ing toruby, and using-rflags, requiring gems in theGemfilewon't work becausebundler/setupis required through-roptions insideRUBYOPT, which are processed after-r` CLI flags.What is your fix for the problem, implemented in this PR?
My fix is to special case
bundle exec rubyand prepend-rbundler/setupto ruby CLI flags, so that gems in theGemfileare made available before other-roptions are processed.Note: The test I wrote for this revealed an issue with
Bundler.whichunder Windows, which I also fixed.Fixes #4025.
Make sure the following tasks are checked