Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ruby -r work with bundle exec #4616

Closed
wants to merge 3 commits into from
Closed

Make ruby -r work with bundle exec #4616

wants to merge 3 commits into from

Commits on May 24, 2021

  1. Remove global before hook from bundle exec specs 

    Several specs don't need these gems installed globally.
    @deivid-rodriguez
    deivid-rodriguez committed May 24, 2021
    Copy the full SHA
    d9d7769 View commit details
    Browse the repository at this point in the history

  2. Fix Bundler.which not working on Windows 

    It was ignoring executable extensions, which is the only hint
`File.executable?` uses on Windows to figure out executability.
    @deivid-rodriguez
    deivid-rodriguez committed May 24, 2021
    Copy the full SHA
    04ab96d View commit details
    Browse the repository at this point in the history

  3. Require bundler/setup before everything else 

    When `bundle exec`'ing to `ruby` itself, direct `-r` flags get run
before `RUBYOPT`, so they get run before `bundler/setup` gets the chance
to be required.

This seems like a flag precedence issue in ruby, but we can workaround
it.
    @deivid-rodriguez
    deivid-rodriguez committed May 24, 2021
    Copy the full SHA
    0b560f0 View commit details
    Browse the repository at this point in the history