-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rubygems and bundler rubocop rules #6487
Conversation
|
No concerns, and I like your plan. |
Thanks to quick response. I'll work Layout, Style, Naming and other cops. |
💪 getting rubygems and bundler closer one step at the time 💪 Btw. I have still plan to add |
I confirmed rule differences with the following way: >> master = (Psych.load_file(".rubocop.yml").keys + Psych.load_file(".rubocop_bundler.yml").keys).uniq
# swith to this branch
>> merge = (Psych.load_file(".rubocop.yml").keys + Psych.load_file(".rubocop_bundler.yml").keys).uniq
>> merge - master
=> ["inherit_from"]
>> master - merge
=> [] There is no missing cops with this PR. |
What was the end-user or developer problem that led to this PR?
We have two rubocop rules between rubygems and bundler. We should move to merge them.
What is your fix for the problem, implemented in this PR?
I merge
.rubocop_bundler.yml
into.rubocop.yml
only non-effect cops at first in this PR. After that, I'll triagerubocop_bundler.yml
cops and modify rubygems or bundler files step by step.@deivid-rodriguez @simi Do you have any concerns about this merger plan?
Make sure the following tasks are checked