Add completion feature #41
Conversation
| return new Promise((resolve, reject) => { | ||
| const line = position.line + 1; | ||
| const column = position.character; | ||
| console.log("line=" , line); |
|
@mattn thanks for your contribution, it look good to me! Do you mind adding a simple guidance in README after |
|
Added small installation instruction for the completion feature. But I'm not native speaker, if you feel wrong, please let me known. |
|
@mattn thanks again! The introduction is neat! I'm not a native speaker as well, let's release it and see people's feedback! |
|
@mattn I'd like to see this with the shell dependancy. You don't need that in the call. It can affect the which (or any) version of the processor is called if you're using rbenv (or rvm). Not sure how Also, adding a filter on the retuned strings to get rid of the methods that aren't really completions. (Operators and such) with: Adding a completionItemKind as the second element to the CompletionItem constructor would be good. Method is probably best. Change the There are a couple more |
* remove shell dependencies * filter non-completion words * add CompletionItemKind * set the keyword it self for filterText instead of Module#method. * remove console.log (without error)
|
@HookyQR Thanks for your review. Fixed. |
|
Wow, awesome, I had booked today to look at building this same thing - thanks @mattn 👍 |
|
|
||
| * rcodetools | ||
|
|
||
| You need to restart vscode after installation of rcodetools. Then type CTRL-Space after the leading words like below. |
There was a problem hiding this comment.
To make this read better in English, maybe try this:
## Autocomplete
To enable method completion in ruby: `gem install rcodetools`. You may need to restart Visual Studio Code the first time.
```ruby
[1, 2, 3].e #<= Press CTRL-Space hereMove the - IntelliSense and autocomplete line from TODO into Features.
|
Fixed problems @HookyQR suggested. Thanks. |
| '--column='+column]); | ||
|
|
||
| var outbuf = [], errbuf = []; | ||
| child.stderr.on('data', (data) => errbuf.push(data.toString())); |
There was a problem hiding this comment.
Push the buffer rather than the string.
|
used Buffer. |
|
@mattn sorry for the late merging. The feature is insanely amazing, thanks for it! |
|
Hey @rebornix, can you package and release a new version with this please. I'm still seeing |
|
@HookyQR It's shiped as 0.5.3 with another PR merged. |
Make sure these boxes are checked before submitting your PR -- thanks in advance!
I wonder that you will have an interesting.