-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds BW::UIActivityViewController for a more Ruby-like interface to activity view controllers #335
Adds BW::UIActivityViewController for a more Ruby-like interface to activity view controllers #335
Conversation
...so that it doesn't try and bitwise an array of String objects. With passing test.
I just patched I suppose the next step could be to have helper methods like |
Huh... Travis returned back this error:
Wonder why, when I'm initializing those constants in the module? |
* refs/heads/master: Do not show warnings about iOS when building for OSX Renamed method physical_camera to available in camera_wrapper. Added method to check if device has a physical camera.
Any feedback on this feature @colinta, @clayallsopp or @supermarin ? |
The API looks solid, I wonder if Travis is running an old version, and doesn't have that AirDrop constant... |
|
Yeah, +1 on @colinta's thoughts. seems like Also editing the readme would be 👍 Travis is yelling because on OS X the Airdrop constant doesn't exist; you should do something like this in the specs: if App.ios?
it "should bitmask array values" do
#...
end
end |
Aha! Thanks for the tip on the tests. I'll try and get it refactored a bit and get the tests working on Travis here in the next few days. FYI, I'm using this code in production in my Textables app to display the |
Is there a preferred way to accept both something like: items = Array(options[:items] || options[:item]) ?? |
Yup, that looks good to me |
* refs/heads/master: Update readme BubbleWrap 1.5.0 deprecate App.user_cache; fixes #346 add BW::Deprecated helper so we can deprecate methods Changes to readme: add get_compass documentation. Typo in get_compass spec. Add test to make sure BW::Location.stop stops updating the compass heading. Adds BW::Location.get_compass & BW::Location.get_compass_once fix /core and /http to be able to load separately 1.5.0.rc1 Add more support for #weak!. Fixes #344 Remove Motion::Project::Config patch Add when_screen_edge_panned for UIScreenEdgePanGestureRecognizer Correct bubble-wrap/media dependencies. fixes #339
…doesn't return a number.
…erridden: 17 (which doesn't exist in the UIModalTransitionStyle enum declaration).
…roller * refs/heads/activity-controller: Add tests for UIActivityViewController. Turns out Apple auto-sets a private transition style that can't be overridden: Passing test for constants change. Adds the ability to return an array of constants if the Constant.get doesn't return a number. Adds UIActivityController wrapper. Conflicts: motion/ui/ui_activity_view_controller_wrapper.rb motion/util/constants.rb spec/motion/util/constants_spec.rb
Once Travis passes, this is good to go! Working tests: |
✨ It passed :) |
Awesome - update the README as well? |
Done. Added it to the |
👍 most excellent, great work! |
Adds BW::UIActivityViewController for a more Ruby-like interface to activity view controllers
Thanks! Glad to contribute! |
- 'bubble-wrap/http' is now deprecated and will be removed in 2.0, see #308 + `BW::UIActivityViewController` wrapper added, see #335 + `BW::NetworkIndicator` added, see #349 + `BW::Location.get_compass` & `BW::Location.get_compass_once`see #348 + `NSString#to_color` ARGB support, see #350 + `Object#method` support for `BW::Reactor`, see #359 * Prevented a possible exception when stopping `BW::Location`, see #358 * Fixed a bug when requiring just 'bubble-wrap/ui'
✨ YAY! |
- 'bubble-wrap/http' is now deprecated and will be removed in 2.0, see rubymotion-community#308 + `BW::UIActivityViewController` wrapper added, see rubymotion-community#335 + `BW::NetworkIndicator` added, see rubymotion-community#349 + `BW::Location.get_compass` & `BW::Location.get_compass_once`see rubymotion-community#348 + `NSString#to_color` ARGB support, see rubymotion-community#350 + `Object#method` support for `BW::Reactor`, see rubymotion-community#359 * Prevented a possible exception when stopping `BW::Location`, see rubymotion-community#358 * Fixed a bug when requiring just 'bubble-wrap/ui'
This is my first attempt. Some guidance on how the DSL should work would be greatly appreciated. I'll write tests once I've nailed down functionality.
Usage:
Let me know if i'm on the right track here.