Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set bundler requirement to be < 3 #203

Closed
wants to merge 1 commit into from
Closed

set bundler requirement to be < 3 #203

wants to merge 1 commit into from

Conversation

colby-swandale
Copy link
Member

Hi! I'm the current release manager for Bundler, i'm going around the ruby ecosystem and seeing if there is anything i can do to help everyone prepare for the upcoming Bundler 2 release.

I noticed that the bundler-audit gem is locked to version 1.X at the moment. We can safely change this requirement to be < 3, Bundler 2 has no breaking changes that will effect this gem.

Thanks!

@mensfeld
Copy link

mensfeld commented Jan 3, 2019

@postmodern ping? :)

@postmodern postmodern closed this in fade761 Jan 3, 2019
@postmodern
Copy link
Member

Went with >= 1.2.0, < 3, since we had issues with < 1.2.0 way back when.

@petergoldstein
Copy link
Contributor

@postmodern Can you publish a 0.6.1 versioned gem with this change incorporated? That would ensure that build pipelines, etc. pick up a gem that can work with bundler 2.0

@ExMember
Copy link

ExMember commented Jan 4, 2019

Travis builds are failing because bundler 2.0 requires at least Ruby 2.3.0 and Travis is running tests with 2.1.8 and 2.24.

- 2.1.8
- 2.2.4

Now might be a good time to add tests for 2.4, 2.5, and 2.6 in addition to dropping Rubies older than 2.3.

@radar
Copy link
Contributor

radar commented Jan 4, 2019

@ExMember I just submitted a PR to fix that here: #204.

@cmur2
Copy link

cmur2 commented Jan 4, 2019

It would be really cool to have a 0.6.1 release published :)

@postmodern
Copy link
Member

Merged and now waiting on Travis. Definitely plan on releasing 0.6.1 before 0.7.0 (which still needs more specs).

@postmodern
Copy link
Member

Hmm, after changing some gem versions in the example bundles, which changed which advisory gets printed, the regular expression in spec/integration_spec.rb stopped matching.

https://travis-ci.org/rubysec/bundler-audit/jobs/475578889
8db8545

@postmodern postmodern mentioned this pull request Jan 7, 2019
@postmodern
Copy link
Member

@eric-pigeon fixed the regexp issue! I will be traveling tomorrow and the next day, so probably expect 0.6.1 to be released Thursday.

mike-burns added a commit to thoughtbot/suspenders that referenced this pull request Jan 11, 2019
Bundler 2.0.1 works with Rails, but [the released version of
bundler-audit hardcodes a dependency on 1.x]. [Downgrade Bundler on Travis]
until [the new bundler-audit] is out.

[the released version of bundler-audit hardcodes a dependency on 1.x]: rubysec/bundler-audit#202
[Downgrade Bundler on Travis]: https://docs.travis-ci.com/user/languages/ruby/#bundler-20
[the new bundler-audit]: rubysec/bundler-audit#203
@davidstosik
Copy link

@postmodern I don't want to sound pressing, but is there anything preventing the 0.6.1 release to happen?

@postmodern
Copy link
Member

I've been offline due to a really bad head cold. I prepped a release, just have to double check it, and push it up.

@postmodern
Copy link
Member

0.6.1 has finally been released!

@davidstosik
Copy link

Thank you!

Web-Go-To added a commit to Web-Go-To/rails_suspenders that referenced this pull request Mar 23, 2023
Bundler 2.0.1 works with Rails, but [the released version of
bundler-audit hardcodes a dependency on 1.x]. [Downgrade Bundler on Travis]
until [the new bundler-audit] is out.

[the released version of bundler-audit hardcodes a dependency on 1.x]: rubysec/bundler-audit#202
[Downgrade Bundler on Travis]: https://docs.travis-ci.com/user/languages/ruby/#bundler-20
[the new bundler-audit]: rubysec/bundler-audit#203
ConnorHerron19 added a commit to ConnorHerron19/rails_suspenders that referenced this pull request Mar 23, 2023
Bundler 2.0.1 works with Rails, but [the released version of
bundler-audit hardcodes a dependency on 1.x]. [Downgrade Bundler on Travis]
until [the new bundler-audit] is out.

[the released version of bundler-audit hardcodes a dependency on 1.x]: rubysec/bundler-audit#202
[Downgrade Bundler on Travis]: https://docs.travis-ci.com/user/languages/ruby/#bundler-20
[the new bundler-audit]: rubysec/bundler-audit#203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants