Bump ActiveRecord dependency #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Rails 6.0.0.beta1 to install Paranoia. I followed the existing convention of existing minor+1 (e.g. Rails 5.2 was released but paranoia allowed '< 5.3') even though the beta1 could be installed if I set it to '< 6.0'. With out this change Bundler was falling back to Paranoia 1.2 when upgrading to Rails 6. Then everything blew up :-) So far everything seems to be working well with 6. I will continue to test and am happy to submit patches if I find anything.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Rails 6.0.0.beta1 to install Paranoia.
I followed the existing convention of existing minor+1 (e.g. Rails 5.2 was released but paranoia allowed '< 5.3') even though the beta1 could be installed if I set it to '< 6.0'.
With out this change Bundler was falling back to Paranoia 1.2 when upgrading to Rails 6. Then everything blew up 💥 😅
So far everything seems to be working well with 6. I will continue to test and am happy to submit patches if I find anything.
If you'd prefer to keep this on a
rails6branch let me know I can update the PR.