Activerecord 6 support #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to test our application on rails 6.0.0.alpha but we can't install this because of the version lock Probably this will be helpful that we can try and report any issues with edge rails
Older versions of activerecord require sqlite ~> 1.3.6, but not in the gemfile, the constraint is enforced when you load the adapter. This allows us toe specify in the environment the version of the gem we'd like to run against.
These versions of rails enforce this version constraint when loading the sqlite adapter so we need to make sure that we always use a compatible version.
The versions we were running against were bumped, so we needed to update which versions were being excluded as they were stale. Rails master (soon to be 6.0.0) doesn't support versions before Ruby 2.5.
jarednorman
force-pushed
the
activerecord-6-support
branch
from
cf58f83
to
c9b1c8a
Compare
|
@jhawthorn with Rails 6rc out any plans in cutting this into a new gem release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes @iggant's changes from #456, but also fixes the CI issues.
Closes #469
Closes #468
Closes #463
Closes #461
Closes #456