Fix common github sync issues #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #245 this deals with a bunch of common issues when syncing repos from github based on the repo reference found in the rubygem links:
.gitappended, which leads to a bunch of interesting problems in conjunction with Githubs GraphQL APIMost notably, for 100% gone 404 repos this puts the repo on an ignore list for 2 weeks, ensuring that it will not pollute github with unneccessary requests. It also drops the
.gitpart at the end of detected repo urls, and ensures the sync does not crash if there are no commits on the repo at all.I could not find info on allowed characters in repo names on github, so I assume
.is permitted, hence it's only restricting the.gitending