Unknown extra fields are not merged correctly when loading. #505
Comments
hainesr
added a commit
to hainesr/rubyzip
that referenced
this issue
Nov 16, 2021
When loading extra fields from both the central directory and local headers, unknown fields were not merged correctly. They were being appended, which means that we end up with the two versions stuck together - in some cases duplicating the field completely. This broke all kinds of things (like calculating the size of a local header) in subtle ways. This commit fixes this by implementing a new `Unknown` extra field type, and making sure that when reading local and central extra fields they are stored and preserved correctly. We cannot assume the unknown fields use the same data in the local and central headers. Fixes rubyzip#505.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When loading extra fields from both the central directory and local headers, unknown fields are not merged correctly. Currently they are appended, which means that we end up with the two versions stuck together.
This potentially causes all sorts of subtle issues, such as the local header size being miscalculated, and so on.
The text was updated successfully, but these errors were encountered: