-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed patches don't terminate the containers #238
Comments
From the
Applying containers/server/docker-entrypoint.sh Lines 49 to 53 in d33dbff
so I'd say the logic here would be:
|
Looks good to me |
rdimaio
added a commit
to rdimaio/rucio-containers
that referenced
this issue
Jan 23, 2024
rcarpa
pushed a commit
that referenced
this issue
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a logic to apply patches inside the container before running rucio.
However, if those patches fail (for example, because the new version of rucio is not compatible with the patch), rucio is still run.
In most cases, this is an non-issue, because this results in a non-valid python file; so rucio fails to start.
Still, it will much better to explicitly fail the container startup when the
patch
command fails.The text was updated successfully, but these errors were encountered: