Skip to content

Commit

Permalink
Merge pull request #4270 from dchristidis/patch-4265-Core__Fix_ATLAS_…
Browse files Browse the repository at this point in the history
…permission_for_declaring_bad_PFNs

Core: Fix ATLAS permission for declaring bad PFNs #4265
  • Loading branch information
bari12 committed Jan 25, 2021
2 parents 2cdd960 + 76bdf47 commit 3c6bdb7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/rucio/core/permission/atlas.py
Expand Up @@ -1139,10 +1139,10 @@ def perm_add_bad_pfns(issuer, kwargs):
:param kwargs: List of arguments for the action.
:returns: True if account is allowed, otherwise False
"""
if kwargs['state'] in [str(BadPFNStatus.BAD), str(BadPFNStatus.TEMPORARY_UNAVAILABLE)]:
if kwargs['state'] in [BadPFNStatus.BAD.name, BadPFNStatus.TEMPORARY_UNAVAILABLE.name]:
is_cloud_admin = bool([acc_attr for acc_attr in list_account_attributes(account=issuer) if (acc_attr['key'].startswith('cloud-')) and (acc_attr['value'] == 'admin')])
return _is_root(issuer) or has_account_attribute(account=issuer, key='admin') or is_cloud_admin
elif kwargs['state'] == str(BadPFNStatus.SUSPICIOUS):
elif kwargs['state'] == BadPFNStatus.SUSPICIOUS.name:
return True
return _is_root(issuer)

Expand Down

0 comments on commit 3c6bdb7

Please sign in to comment.