Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot declare bad PFNs #4265

Closed
dchristidis opened this issue Jan 25, 2021 · 0 comments · Fixed by #4270
Closed

Cannot declare bad PFNs #4265

dchristidis opened this issue Jan 25, 2021 · 0 comments · Fixed by #4270
Assignees
@dchristidis
Labels
bug Core & Internals
Milestone
1.24.2

Comments

@dchristidis
Copy link
Contributor

Motivation

We have identified another regression from the recent SQLAlchemy changes. In this part of the code, state can be BAD, but str(BadPFNStatus.BAD) evaluates to 'BadPFNStatus.BAD'.

Modification

Use BadPFNStatus.*.name instead.
@dchristidis dchristidis changed the title Cannot declare bad PNFs Cannot declare bad PFNs Jan 25, 2021
@dchristidis dchristidis assigned dchristidis and unassigned mlassnig Jan 25, 2021
@dchristidis dchristidis mentioned this issue Jan 25, 2021
Closed
dchristidis added a commit to dchristidis/rucio that referenced this issue Jan 25, 2021
@dchristidis
Core: Fix ATLAS permission for declaring bad PFNs rucio#4265
4b8c4f4 
This is a stopgap solution. It should be followed up in issue rucio#4269.
@dchristidis dchristidis mentioned this issue Jan 25, 2021
Merged
dchristidis added a commit to dchristidis/rucio that referenced this issue Jan 25, 2021
@dchristidis
Core: Fix ATLAS permission for declaring bad PFNs rucio#4265
76bdf47 
This is a stopgap solution. It should be followed up in issue rucio#4269.
bari12 added a commit that referenced this issue Jan 25, 2021
@bari12
Merge pull request #4270 from dchristidis/patch-4265-Core__Fix_ATLAS_…
3c6bdb7 
…permission_for_declaring_bad_PFNs

Core: Fix ATLAS permission for declaring bad PFNs #4265
bari12 pushed a commit that referenced this issue Jan 25, 2021
@dchristidis @bari12
Core: Fix ATLAS permission for declaring bad PFNs #4265
ca5427d 
This is a stopgap solution. It should be followed up in issue #4269.
@bari12 bari12 added this to the 1.24.2 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchristidis dchristidis

Labels
bug Core & Internals
Projects
None yet
Milestone
1.24.2
Development

Successfully merging a pull request may close this issue.

Core: Fix ATLAS permission for declaring bad PFNs #4265 dchristidis/rucio
3 participants
@mlassnig @bari12 @dchristidis