Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new RULE_OK notification for all rules #1115

Closed
bari12 opened this issue Apr 30, 2018 · 0 comments
Closed

Create a new RULE_OK notification for all rules #1115

bari12 opened this issue Apr 30, 2018 · 0 comments
Assignees
@bari12
Labels
enhancement Messaging Rules
Milestone
1.16.1

Comments

@bari12
Copy link
Member

bari12 commented Apr 30, 2018 •
edited
Loading

Motivation

For NONE grouped rules no DATASETLOCK_OK notifications are created, as they do not have datasetlocks.

It would be helpful to have a new notification RULE_OK which is invoked for all rules when they reach the OK state. The notification mode (CLOSE) should be respected the same way as DATASETLOCK_OK notifications are handled.
@bari12 bari12 added this to the 1.16.1 milestone Apr 30, 2018
@bari12 bari12 self-assigned this Apr 30, 2018
@bari12 bari12 changed the title Create "fake" DATASETLOCK_OK notification for NONE grouped rules Create a new RULE_OK notification for all rules May 7, 2018
bari12 added a commit to bari12/rucio that referenced this issue May 7, 2018
@bari12
Rules: Added a RULE_OK notification; Fix rucio#1115
57c0d03
This was referenced May 7, 2018
Merged
Merged
bari12 added a commit that referenced this issue May 8, 2018
@bari12
Merge pull request #1136 from bari12/patch-1115-RULE_OK_notification
82942cd 
Rules: Added a RULE_OK notification; Fix #1115
bari12 added a commit that referenced this issue May 8, 2018
@bari12
Merge pull request #1135 from bari12/patch-1115-RULE_OK_notification
bfe3863 
Rules: Added a RULE_OK notification; Fix #1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bari12 bari12

Labels
enhancement Messaging Rules
Projects
None yet
Milestone
1.16.1
Development

No branches or pull requests
1 participant
@bari12