-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pylint tests on travis #209
Comments
Having a simple test on all files to check that we don't have pylint errors would be good as well. |
Running it over all files can be enabled easily, will just take a bit longer. |
There is two things: For the errors, testing everything is fine, because there really should not be any error in the code. Testing for score though you should do file by file. If you get a score for everything, the few files changed in the PR will not really move the general score, although the files themselves might have a very bad one. |
Testing: correctly get list of changed files for travis pylint test #209
Testing: correctly get list of changed files for travis pylint test #209
Testing: correctly get list of changed files for travis pylint test #209
Motivation
The current command to get the list of changed files for a PR, which was originally taken from the old build bot script, does not work with the travis workflow and has to be fixed.
Modification
Expected behavior
The text was updated successfully, but these errors were encountered: