Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint tests on travis #209

Closed
tbeerman opened this issue Nov 27, 2017 · 3 comments
Closed

Fix pylint tests on travis #209

tbeerman opened this issue Nov 27, 2017 · 3 comments
Assignees
Milestone

Comments

@tbeerman
Copy link
Contributor

Motivation

The current command to get the list of changed files for a PR, which was originally taken from the old build bot script, does not work with the travis workflow and has to be fixed.

Modification

Expected behavior

@tbeerman tbeerman self-assigned this Nov 27, 2017
@bari12 bari12 added this to the 1.13.4 milestone Nov 27, 2017
@vingar
Copy link
Contributor

vingar commented Nov 27, 2017

Having a simple test on all files to check that we don't have pylint errors would be good as well.
I quickly googled travis+pylint and few options exists apparently in travis but I didn't have time to investigate more. Something to look ?

@tbeerman
Copy link
Contributor Author

Running it over all files can be enabled easily, will just take a bit longer.

@bari12
Copy link
Member

bari12 commented Nov 28, 2017

There is two things: For the errors, testing everything is fine, because there really should not be any error in the code. Testing for score though you should do file by file. If you get a score for everything, the few files changed in the PR will not really move the general score, although the files themselves might have a very bad one.

@bari12 bari12 modified the milestones: 1.13.4, 1.14.1 Nov 28, 2017
bari12 added a commit that referenced this issue Nov 29, 2017
Testing: correctly get list of changed files for travis pylint test #209
bari12 added a commit that referenced this issue Nov 29, 2017
Testing: correctly get list of changed files for travis pylint test #209
@bari12 bari12 closed this as completed Nov 29, 2017
rucio pushed a commit that referenced this issue Feb 6, 2018
Testing: correctly get list of changed files for travis pylint test #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants