Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly passing strings to SQLAlchemy without an explicit text() declaration #2732

Closed
bjwhite-fnal opened this issue Jul 12, 2019 · 0 comments · Fixed by #2733
Closed

Incorrectly passing strings to SQLAlchemy without an explicit text() declaration #2732

bjwhite-fnal opened this issue Jul 12, 2019 · 0 comments · Fixed by #2733
Assignees
@bjwhite-fnal
Labels
bug Core & Internals
Milestone
1.20.3

Comments

@bjwhite-fnal
Copy link
Member

Motivation

Rucio was recently upgraded to use SQLAlchemy >=1.3.0 which changed the behavior of SQLAlchemy to raise an exception as opposed to a warning when passing strings as part of a query.
#2494

Modification

Declare text as text to keep SQLAlchemy happy.
This was referenced Jul 12, 2019
Merged
Merged
bari12 added a commit that referenced this issue Jul 18, 2019
@bari12
Merge pull request #2733 from bjwhite-fnal/patch-2732-Declare_strings…
50ed7e5 
…_passed_to_SQLAlchemy_as_text_explicitly_

Core & Internals: Declare strings passed to SQLAlchemy as text explicitly. Fix #2732
bari12 added a commit that referenced this issue Jul 18, 2019
@bari12
Merge pull request #2734 from bjwhite-fnal/patch-2732-Declare_strings…
70841c5 
…_passed_to_SQLAlchemy_as_text_explicitly_

Core & Internals: Declare strings passed to SQLAlchemy as text explicitly. Fix #2732
@bari12 bari12 added this to the 1.20.3 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjwhite-fnal bjwhite-fnal

Labels
bug Core & Internals
Projects
None yet
Milestone
1.20.3
Development

Successfully merging a pull request may close this issue.

Core & Internals: Declare strings passed to SQLAlchemy as text explicitly. Fix #2732
2 participants
@bari12 @bjwhite-fnal