Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating rule comment #4116

Closed
nsmith- opened this issue Nov 9, 2020 · 1 comment · Fixed by #4471
Closed

Allow updating rule comment #4116

nsmith- opened this issue Nov 9, 2020 · 1 comment · Fixed by #4471
Labels
good first issue Rules
Milestone
1.25.2-clients

Comments

@nsmith-
Copy link
Contributor

nsmith- commented Nov 9, 2020

Motivation

It would be nice to also allow updating the comment field in the update_replication_rule API.

Modification

Probably just need to add comment to the list in

rucio/lib/rucio/core/rule.py

Line 1281 in 9ab7440

valid_options = ['locked', 'lifetime', 'account', 'state', 'activity', 'source_replica_expression', 'cancel_requests', 'priority', 'child_rule_id', 'eol_at', 'meta', 'purge_replicas']

@nsmith-
Copy link
Contributor Author

nsmith- commented Nov 9, 2020

As an aside, it seems in add_replication_rule it is “comment” but in the dictionary returned from list_replication_rules it is “comments”

DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 19, 2021
@DhruvSondhi
Rules: Upadating Comments in Rules Fix rucio#4116
5912117
DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 19, 2021
@DhruvSondhi
Rules: Upadating Comments in Rules Fix rucio#4116
c51a5a6
dynamic-entropy added a commit to dynamic-entropy/rucio that referenced this issue Mar 20, 2021
@dynamic-entropy
Rules: added option to update comment in update_rule command Fix ruci…
21a32ab 
…o#4116
@dynamic-entropy dynamic-entropy mentioned this issue Mar 20, 2021
Merged
DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 21, 2021
@DhruvSondhi
Rule: Updating comments in Rule Fix rucio#4116
f43b7ba
DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 21, 2021
@DhruvSondhi
Rules: Upadating Comments in Rules Fix rucio#4116
a985f0e
DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 23, 2021
@DhruvSondhi
Rules: Upadating Comments in Rules Fix rucio#4116
a0ada9b
DhruvSondhi added a commit to DhruvSondhi/rucio that referenced this issue Mar 24, 2021
@DhruvSondhi
Rules: Upadating Comments in Rules Fix rucio#4116
c1225fc
bari12 added a commit that referenced this issue Mar 26, 2021
@bari12
Merge pull request #4471 from dynamic-entropy/patch-4116-allow_updati…
22e8378 
…ng_rule_comment

Rules: added option to update comment in update_rule command Fix #4116
bari12 pushed a commit that referenced this issue Mar 26, 2021
@dynamic-entropy @bari12
Rules: added option to update comment in update_rule command Fix #4116
fa563c6
@bari12 bari12 added this to the 1.25.2-clients milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Rules
Projects
None yet
Milestone
1.25.2-clients
Development

Successfully merging a pull request may close this issue.

Rules: added option to update comment in update_rule command Fix #4116 dynamic-entropy/rucio
2 participants
@bari12 @nsmith-