Rules: added option to update comment in update_rule command Fix #4116 #4471
Conversation
| @@ -1303,6 +1304,9 @@ def update_rule(rule_id, options, session=None): | |||
| if key == 'source_replica_expression': | |||
| rule.source_replica_expression = options['source_replica_expression'] | |||
|
|
|||
| if key == 'comment': | |||
| rule.comments = options['comment'] | |||
There was a problem hiding this comment.
is this called 'comments' in the rule definition? hmmmm. that's a weird inconsistency. @bari12 what do you think?
There was a problem hiding this comment.
yes,
rucio/lib/rucio/db/sqla/models.py
Line 954 in 4c5f830
And changing it to "comments" will demand changes in the "comment" option of add-rule command as well. But will surely be less involved than changing the rule definition to "comment".
There was a problem hiding this comment.
One option is to change the client API to add comments as an alias of comment and eventually send a deprecation warning for the comment field name.
There was a problem hiding this comment.
I think that is fine, to change it in the database is a bit more complicated obviously. But the alias is good.
Rules: added option to update a comment in update_rule command Fix #4116
Modified CLI to allow users to update comment for a rule, with the "--comment" option.
@nsmith- Kindly review, if this is the desired behaviour.