-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/Re-design core.meta
module
#5224
Comments
Would |
This would be a bit confusing with the actual metadata interface (in core/did_meta_plugins). I think I would call it somewhat like |
For the rest api - it advisable to make a legacy endpoint that responds to |
I think a new one + legacy, and we deprecate the legacy one over time. |
Changes: * Rename core.meta to core.meta_conventions * Rename DIDKey -> DIDMetaConventionsKey * Rename DIDKeyValue -> DIDMetaConventionsConstraints * Update docstrings to reflect naming, more descriptive * Typing on *.meta_conventions
Changes: * Rename core.meta to core.meta_conventions * Rename DIDKey -> DIDMetaConventionsKey * Rename DIDKeyValue -> DIDMetaConventionsConstraints * Update docstrings to reflect naming, more descriptive * Typing on *.meta_conventions
Changes: * Rename core.meta to core.meta_conventions * Rename DIDKey -> DIDMetaConventionsKey * Rename DIDKeyValue -> DIDMetaConventionsConstraints * Update docstrings to reflect naming, more descriptive * Typing on *.meta_conventions
Changes: * Rename core.meta to core.meta_conventions * Rename DIDKey -> DIDMetaConventionsKey * Rename DIDKeyValue -> DIDMetaConventionsConstraints * Update docstrings to reflect naming, more descriptive * Typing on *.meta_conventions
Motivation
Currently the
core.meta.py
module makes it look like it deals with metadata directly, while this is not true, it is about metadata conventions and enforcing these. To make this more clear and avoid confusion, parts of the module (module name, method names, descriptions) should be updated. I would suggest to name everything asmeta_conventions
.Modification
The text was updated successfully, but these errors were encountered: