Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/Re-design core.meta module #5224

Closed
bari12 opened this issue Feb 10, 2022 · 4 comments
Closed

Update/Re-design core.meta module #5224

bari12 opened this issue Feb 10, 2022 · 4 comments
Assignees
@robbarnsley @voetberg
Labels
enhancement Metadata
Milestone
34.0.0

Comments

@bari12
Copy link
Member

bari12 commented Feb 10, 2022

Motivation

Currently the core.meta.py module makes it look like it deals with metadata directly, while this is not true, it is about metadata conventions and enforcing these. To make this more clear and avoid confusion, parts of the module (module name, method names, descriptions) should be updated. I would suggest to name everything as meta_conventions.

Modification

  • Change the nodule name, method names, descriptions
  • Check that the new metadata handling with the different plugins is actually compatible to this
@voetberg
Copy link
Contributor

Would metadata_interface make more sense? While it isn't the metadata itself, it does control interactions with metadata

voetberg added a commit to voetberg/rucio that referenced this issue Jan 17, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions rucio#5224
eb100b4
voetberg added a commit to voetberg/rucio that referenced this issue Jan 17, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions rucio#5224
623ff37
@bari12
Copy link
Member Author

bari12 commented Jan 17, 2024

This would be a bit confusing with the actual metadata interface (in core/did_meta_plugins). I think I would call it somewhat like metadata_conventions?

@voetberg
Copy link
Contributor

voetberg commented Jan 25, 2024 •
edited
Loading

For the rest api - it advisable to make a legacy endpoint that responds to /meta/ and a new one for /meta_conventions/, or just leave it as meta?

@bari12
Copy link
Member Author

bari12 commented Jan 26, 2024

I think a new one + legacy, and we deprecate the legacy one over time.

voetberg added a commit to voetberg/rucio that referenced this issue Jan 26, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions rucio#5224
7a1e95a
voetberg added a commit to voetberg/rucio that referenced this issue Jan 26, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions rucio#5224
fa5c5f9
voetberg added a commit to voetberg/rucio that referenced this issue Feb 6, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions rucio#5224
de7142c
voetberg added a commit to voetberg/rucio that referenced this issue Feb 21, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions Fix rucio#5224
ef7268c 
Changes:
	* Rename core.meta to core.meta_conventions
	* Rename DIDKey -> DIDMetaConventionsKey
	* Rename DIDKeyValue -> DIDMetaConventionsConstraints
	* Update docstrings to reflect naming, more descriptive
	* Typing on *.meta_conventions
voetberg added a commit to voetberg/rucio that referenced this issue Feb 29, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions Fix rucio#5224
0dcbebc 
Changes:
	* Rename core.meta to core.meta_conventions
	* Rename DIDKey -> DIDMetaConventionsKey
	* Rename DIDKeyValue -> DIDMetaConventionsConstraints
	* Update docstrings to reflect naming, more descriptive
	* Typing on *.meta_conventions
voetberg added a commit to voetberg/rucio that referenced this issue Feb 29, 2024
@voetberg
Meta: sqla2.0 update for 'meta_conventions'; Fix rucio#5224
0ca97f4
voetberg added a commit to voetberg/rucio that referenced this issue Mar 4, 2024
@voetberg
Metadata: sqla2.0 update for 'meta_conventions'; Fix rucio#5224
ad95d5a
voetberg added a commit to voetberg/rucio that referenced this issue Mar 6, 2024
@voetberg
Metadata: sqla2.0 update for 'meta_conventions'; Fix rucio#5224
32710a8
@bari12 bari12 closed this as completed in ea765b7 Mar 7, 2024
bari12 pushed a commit that referenced this issue Mar 7, 2024
@voetberg @bari12
Metadata: sqla2.0 update for 'meta_conventions'; Fix #5224
e85183f
voetberg added a commit to voetberg/rucio that referenced this issue Mar 21, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions Fix rucio#5224
8ac30bb 
Changes:
	* Rename core.meta to core.meta_conventions
	* Rename DIDKey -> DIDMetaConventionsKey
	* Rename DIDKeyValue -> DIDMetaConventionsConstraints
	* Update docstrings to reflect naming, more descriptive
	* Typing on *.meta_conventions
voetberg added a commit to voetberg/rucio that referenced this issue Mar 21, 2024
@voetberg
Metadata: sqla2.0 update for 'meta_conventions'; Fix rucio#5224
c333303
voetberg added a commit to voetberg/rucio that referenced this issue Apr 15, 2024
@voetberg
Metadata: Rename core.meta to core.meta_conventions Fix rucio#5224
a3ee86b 
Changes:
	* Rename core.meta to core.meta_conventions
	* Rename DIDKey -> DIDMetaConventionsKey
	* Rename DIDKeyValue -> DIDMetaConventionsConstraints
	* Update docstrings to reflect naming, more descriptive
	* Typing on *.meta_conventions
voetberg added a commit to voetberg/rucio that referenced this issue Apr 15, 2024
@voetberg
Metadata: sqla2.0 update for 'meta_conventions'; Fix rucio#5224
790c4b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robbarnsley robbarnsley

@voetberg voetberg

Labels
enhancement Metadata
Projects
No open projects
Rucio 1.29 "Into the Donkeyverse" release roadmap
Status: Done
Rucio 32 "The Good, The Bad and the Donkey" major release roadmap
Status: Delayed
Rucio 34 "Donkey Potter and the Data Cache" roadmap
Status: Done
Milestone
34.0.0
Development

No branches or pull requests
3 participants
@robbarnsley @bari12 @voetberg