Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the add header CI/CD job #5389

Closed
joeldierkes opened this issue Mar 25, 2022 · 0 comments
Closed

Disable the add header CI/CD job #5389

joeldierkes opened this issue Mar 25, 2022 · 0 comments
Assignees
@joeldierkes
Labels
patch Testing
Milestone
1.28.1

Comments

@joeldierkes
Copy link
Contributor

Motivation

The add_header job created too much noise in the commits. Often times there are multiple line changes per python file per PR.

Modification

Disable the add_header job and re-evaluate the usage.
@joeldierkes joeldierkes self-assigned this Mar 25, 2022
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Mar 25, 2022
Delete the add_header script rucio#5389
4e8bfe7 
The `add_header` script output is too volatile for the usage in this
project. The PRs get polluted with the changes made to each python file
header. Merges and other git actions can not be performed easily anymore.

The future of the python file headers and the acknowledgement of open source
contributors need to be discussed and re-evaluated. The job gets disabled
temporarily.
bari12 added a commit that referenced this issue Mar 30, 2022
@bari12
Merge pull request #5390 from joeldierkes/patch-5389-Disable_the_add_…
5d0fdb8 
…header_CI_CD_job

Delete the `add_header` script #5389
bari12 pushed a commit that referenced this issue Mar 30, 2022
@bari12
Delete the add_header script #5389
045868d 
The `add_header` script output is too volatile for the usage in this
project. The PRs get polluted with the changes made to each python file
header. Merges and other git actions can not be performed easily anymore.

The future of the python file headers and the acknowledgement of open source
contributors need to be discussed and re-evaluated. The job gets disabled
temporarily.
@bari12 bari12 added the Testing label Mar 30, 2022
@bari12 bari12 added this to the 1.28.1 milestone Mar 30, 2022
@bari12 bari12 closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeldierkes joeldierkes

Labels
patch Testing
Projects
None yet
Milestone
1.28.1
Development

No branches or pull requests
2 participants
@bari12 @joeldierkes