Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the add_header script #5389 #5390

Merged

Conversation

joeldierkes
Copy link
Contributor

The add_header script output is too volatile for the usage in this
project. The PRs get polluted with the changes made to each python file
header. Merges and other git actions can not be performed easily anymore.

The future of the python file headers and the acknowledgement of open source
contributors need to be discussed and re-evaluated. The job gets disabled
temporarily.

@joeldierkes joeldierkes requested a review from maany as a code owner March 25, 2022 12:01
The `add_header` script output is too volatile for the usage in this
project. The PRs get polluted with the changes made to each python file
header. Merges and other git actions can not be performed easily anymore.

The future of the python file headers and the acknowledgement of open source
contributors need to be discussed and re-evaluated. The job gets disabled
temporarily.
@joeldierkes joeldierkes force-pushed the patch-5389-Disable_the_add_header_CI_CD_job branch from ea1bcbc to 4e8bfe7 Compare March 25, 2022 12:03
@joeldierkes joeldierkes changed the title Delete the add_header script Delete the add_header script #5389 Mar 25, 2022
Copy link
Member

@maany maany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see it go. But LGTM. Might have to rebase PRs merged after this.

@maany
Copy link
Member

maany commented Mar 28, 2022

@joeldierkes can you re-run the CI. Looks like network errors for the failing jobs.

@bari12 bari12 merged commit 5d0fdb8 into rucio:master Mar 30, 2022
@joeldierkes joeldierkes deleted the patch-5389-Disable_the_add_header_CI_CD_job branch April 5, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants