Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrequent failing test_download_dataset test #5887

Closed
joeldierkes opened this issue Sep 21, 2022 · 0 comments · Fixed by #5888
Closed

Infrequent failing test_download_dataset test #5887

joeldierkes opened this issue Sep 21, 2022 · 0 comments · Fixed by #5888
Assignees
@joeldierkes
Labels
bug Testing
Milestone
1.29.6

Comments

@joeldierkes
Copy link
Contributor

Motivation

The test_download_dataset is failing sometimes with the error:

[gw1] linux -- Python 3.9.9 /usr/bin/python
test_bin_rucio.py:1048: in test_download_dataset
    assert re.search(search, err) is not None
E   AssertionError: assert None is not None
E    +  where None = <function search at 0x7f252a347ca0>('file_OQAYTFTGUO successfully downloaded',

As @yuyiguo pointed out in #5872 (comment), the test does not download the dataset because it is already available locally. There seems to be no pattern on when the test is failing and when not.

2022-09-19 22:32:02,995	INFO	Preparing download of data13_hip:file_OQAYTFTGUO
2022-09-19 22:32:02,995	INFO	File exists already locally: data13_hip:file_OQAYTFTGUO

Modification

Remove the file before the download, so it does not exist locally and thus needs to be downloaded.
@joeldierkes joeldierkes self-assigned this Sep 21, 2022
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Sep 21, 2022
Remove the local file in test_download_dataset before download ruci…
2437b12 
…o#5887

The local created file in `test_download_dataset`, which gets uploaded, is not
removed before the download. This results in a failing test, since it is cached
and thus does not need to be downloaded.
@joeldierkes joeldierkes linked a pull request Sep 21, 2022 that will close this issue
Remove the local file in test_download_dataset before download #5887 #5888
Merged
bari12 added a commit that referenced this issue Sep 30, 2022
@bari12
Merge pull request #5888 from joeldierkes/feature-5887-infrequent-fai…
4e2556f 
…ling-download-dataset-test

Remove the local file in `test_download_dataset` before download #5887
bari12 pushed a commit that referenced this issue Sep 30, 2022
@bari12
Remove the local file in test_download_dataset before download #5887
2cb1092 
The local created file in `test_download_dataset`, which gets uploaded, is not
removed before the download. This results in a failing test, since it is cached
and thus does not need to be downloaded.
@bari12 bari12 added this to the 1.29.6 milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeldierkes joeldierkes

Labels
bug Testing
Projects
None yet
Milestone
1.29.6
Development

Successfully merging a pull request may close this issue.

Remove the local file in test_download_dataset before download #5887 joeldierkes/rucio
2 participants
@bari12 @joeldierkes