Remove the local file in test_download_dataset before download #5887

[joeldierkes]

The local created file in test_download_dataset, which gets uploaded, is not
removed before the download. This results in a failing test, since it is cached
and thus does not need to be downloaded.

[yuyiguo]

Should we check if the file is there or not, before removing it? Because sometimes the test does pass like Martin restarted the test today.

[joeldierkes]

The problem I have with that is that the file should not be deleted in the first place. Uploading a file does not delete it to my knowledge. I think the test fails because due to some internal behavior the file is recognized sometimes, and sometimes not (which is a very unsatisfying statement, I know).

I think it would be beneficial to know if the file gets deleted and thus can not be deleted anymore, since this should not happen in the first place.

[joeldierkes]

@yuyiguo @bari12 does that make sense?

[yuyiguo]

How about below?

try:
os.remove(file)
except:
pass

[joeldierkes]

I think it would be beneficial to know if the file gets deleted and thus can not be deleted anymore, since this should not happen in the first place.

Okay, this sentence is probably a bit ambiguous.
I meant to say that we want to know if the file does not exist anymore, since we don't explicitly delete it. I think it would not be beneficial to silent the error.

[yuyiguo]

I got you now. It is depending on what the test is for. The current fixing will give the failing test to someone whose PR may not relate to the failed issue at all. But it is ok if the test will eventually be fixed after we know why the file sometimes "disappeared".