Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Update test_rucio_bin to use fixtures, #6529 #6561

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voetberg
Copy link
Contributor

Near re-write of test_rucio_bin to change the hard-coding to fixtures and temp_factories. Extension of #6531

Tried to leave functionality unchanged.

@voetberg voetberg marked this pull request as draft March 13, 2024 20:43
@voetberg voetberg force-pushed the patch-6529-fixtures_test_bin branch from e175bc2 to 08b9ee6 Compare March 15, 2024 19:53
@bari12 bari12 requested a review from rdimaio June 4, 2024 12:18
@bari12
Copy link
Member

bari12 commented Jun 4, 2024

I think this is a good idea. @rdimaio can you please have a look as well.

@rdimaio
Copy link
Contributor

rdimaio commented Jun 4, 2024

I think this is a good idea. @rdimaio can you please have a look as well.

It's marked as draft - @voetberg is it ready for review? Feel free to mark it as ready in that case

@voetberg
Copy link
Contributor Author

voetberg commented Jun 4, 2024

@rdimaio That's right it is a draft - I was having some issues getting everything to pass again so put this on the back-burner.

@rdimaio rdimaio removed their request for review June 4, 2024 13:14
@voetberg voetberg force-pushed the patch-6529-fixtures_test_bin branch 2 times, most recently from 3aa0295 to 59960a5 Compare June 17, 2024 15:05
@voetberg voetberg force-pushed the patch-6529-fixtures_test_bin branch 4 times, most recently from f84a8c3 to d9b9135 Compare June 21, 2024 14:12
@voetberg voetberg force-pushed the patch-6529-fixtures_test_bin branch from d9b9135 to 7a75b5b Compare June 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants