-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Update test_rucio_bin to use fixtures, #6529 #6561
Open
voetberg
wants to merge
4
commits into
rucio:master
Choose a base branch
from
voetberg:patch-6529-fixtures_test_bin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e175bc2
to
08b9ee6
Compare
I think this is a good idea. @rdimaio can you please have a look as well. |
@rdimaio That's right it is a draft - I was having some issues getting everything to pass again so put this on the back-burner. |
3aa0295
to
59960a5
Compare
d9b9135
to
7a75b5b
Compare
c8b9091
to
4bbe9aa
Compare
Need to solve the mystery of why the multivo non-auto oidc auth tests are failing, but I do not expect that to change the PR contents dramatically |
391d4b2
to
fc72878
Compare
fc72878
to
dc14c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Near re-write of
test_rucio_bin
to change the hard-coding to fixtures and temp_factories. Extension of #6531Tried to leave functionality unchanged.