Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrapping errors for detecting custom errors #7

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

itsmihir
Copy link
Collaborator

@itsmihir itsmihir commented Jan 5, 2023

Description of the change

pongo2 was converting the error to string, so detecting any other custom error was impossible. With these changes, we can detect custom errors.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@itsmihir itsmihir assigned itsmihir and unassigned itsmihir Jan 5, 2023
Copy link
Collaborator

@sprksh sprksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmihir itsmihir merged commit 657f17c into master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants