Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing proguard rules for the sqlcipher dependency #432

Merged
merged 4 commits into from
May 28, 2024
Merged

fix: add missing proguard rules for the sqlcipher dependency #432

merged 4 commits into from
May 28, 2024

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented May 21, 2024 •
edited
Loading

Description

Added missing ProGuard rules for the SQLCipher classes.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey 1abhishekpandey self-assigned this May 21, 2024
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review May 27, 2024 06:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@itsdebs itsdebs self-requested a review May 28, 2024 06:52
@1abhishekpandey 1abhishekpandey merged commit 98cacc1 into develop May 28, 2024
8 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix/sdk-1858-add-the-missing-sqlcipher-proguard-rules branch May 28, 2024 14:49
@1abhishekpandey 1abhishekpandey linked an issue May 28, 2024 that may be closed by this pull request
BUG : Outdated ProGuard rules after migrating SQLCipher #430
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

@itsdebs itsdebs itsdebs approved these changes

Assignees

@1abhishekpandey 1abhishekpandey

Labels
Ready for review v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG : Outdated ProGuard rules after migrating SQLCipher
3 participants
@1abhishekpandey @ChryssaAliferi @itsdebs