Skip to content

Commit

Permalink
pulled latest develop
Browse files Browse the repository at this point in the history
  • Loading branch information
pallabmaiti committed Nov 19, 2022
2 parents b6c8e56 + a38e1d1 commit 81290d5
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/slack-notify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
PROJECT_NAME: 'iOS SDK'
with:
channel-id: ${{ secrets.SLACK_RELEASE_CHANNEL_ID }}
channel-id: "${{ secrets.SLACK_RELEASE_CHANNEL_ID }}"
payload: |
{
"blocks": [
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.7.2](https://github.com/rudderlabs/rudder-sdk-ios/compare/v1.7.1...v1.7.2) (2022-11-17)


### Bug Fixes

* initialise `eventFiltering` object even when `destinations` is empty ([3a5c1c4](https://github.com/rudderlabs/rudder-sdk-ios/commit/3a5c1c412c63c4ca0a9c57538135fbfde238a69a))

### 1.7.1 (2022-11-04)


Expand Down
4 changes: 2 additions & 2 deletions Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- Rudder (1.7.1)
- Rudder (1.7.2)

DEPENDENCIES:
- Rudder (from `.`)
Expand All @@ -9,7 +9,7 @@ EXTERNAL SOURCES:
:path: "."

SPEC CHECKSUMS:
Rudder: 61568212171ddc2efe7785d0a6a0de589d181370
Rudder: 473a45c60ca589c1f9bce568f4837c46a1b15de4

PODFILE CHECKSUM: b22a79db44ea2c78e3500063ff2c7312ef613413

Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<p align="center">
<a href="https://cocoapods.org/pods/Rudder">
<img src="https://img.shields.io/static/v1?label=pod&message=v1.7.1&color=blue&style=flat">
<img src="https://img.shields.io/static/v1?label=pod&message=v1.7.2&color=blue&style=flat">
</a>
</p>

Expand Down Expand Up @@ -39,15 +39,15 @@ The iOS SDK is available through [**CocoaPods**](https://cocoapods.org), [**Cart
To install the SDK, simply add the following line to your Podfile:

```xcode
pod 'Rudder', '1.7.1'
pod 'Rudder', '1.7.2'
```

### Carthage

For Carthage support, add the following line to your `Cartfile`:

```xcode
github "rudderlabs/rudder-sdk-ios" "v1.7.1"
github "rudderlabs/rudder-sdk-ios" "v1.7.2"
```

> Remember to include the following code in all `.m` and `.h` files where you want to refer to or use the RudderStack SDK classes, as shown:
Expand All @@ -71,7 +71,7 @@ You can also add the RudderStack iOS SDK via Swift Package Mangaer, via one of t

* Enter the package repository (`git@github.com:rudderlabs/rudder-sdk-ios.git`) in the search bar.

* In **Dependency Rule**, select **Up to Next Major Version** and enter `1.7.1` as the value, as shown:
* In **Dependency Rule**, select **Up to Next Major Version** and enter `1.7.2` as the value, as shown:

![Setting dependency](https://user-images.githubusercontent.com/59817155/145574696-8c849749-13e0-40d5-aacb-3fccb5c8e67d.png)

Expand Down Expand Up @@ -99,7 +99,7 @@ let package = Package(
],
dependencies: [
// Dependencies declare other packages that this package depends on.
.package(url: "git@github.com:rudderlabs/rudder-sdk-ios.git", from: "1.7.1")
.package(url: "git@github.com:rudderlabs/rudder-sdk-ios.git", from: "1.7.2")
],
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
Expand Down
2 changes: 1 addition & 1 deletion Sources/Classes/Public/RSVersion.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
#ifndef RSVersion_h
#define RSVersion_h

NSString *const SDK_VERSION = @"1.7.1";
NSString *const SDK_VERSION = @"1.7.2";

#endif /* RSVersion_h */
2 changes: 1 addition & 1 deletion Sources/Classes/RSEventRepository.m
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ - (void) __initiateSDK {
[strongSelf __initiateFactories: serverConfig.destinations];
[RSLogger logDebug:@"EventRepository: initiating event filtering plugin for device mode destinations"];
strongSelf->eventFilteringPlugin = [[RSEventFilteringPlugin alloc] init:serverConfig.destinations];

} else {
strongSelf->eventFilteringPlugin = [[RSEventFilteringPlugin alloc] init];
[RSLogger logDebug:@"EventRepository: no device mode present"];
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"version": "1.7.1",
"version": "1.7.2",
"description": "Rudder is a platform for collecting, storing and routing customer event data to dozens of tools"
}
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sonar.qualitygate.wait=false
sonar.projectKey=rudderlabs_rudder-sdk-ios
sonar.organization=rudderlabs
sonar.projectName=RudderStack iOS SDK
sonar.projectVersion=1.7.1
sonar.projectVersion=1.7.2

# C/C++/Objective-C related details
sonar.cfamily.compile-commands=compile_commands.json
Expand Down

0 comments on commit 81290d5

Please sign in to comment.